[Fix] Prevent Poetry compilation problems in non-Linux environments #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benvii
approved these changes
Oct 7, 2024
gen-ai-orchestrator-server/pom.xml
Outdated
| @@ -50,6 +50,7 @@ | |||
| <groupId>io.fabric8</groupId> | |||
| <artifactId>docker-maven-plugin</artifactId> | |||
| <configuration> | |||
| <verbose>true</verbose> | |||
There was a problem hiding this comment.
You should remove it, use it only for debug purposes.
| POETRY_CACHE_DIR='/var/cache/pypoetry' | ||
|
|
||
| # Install Poetry | ||
| RUN pip install "poetry==$POETRY_VERSION" |
There was a problem hiding this comment.
I'm not sure fabrikIO correctly support it we it would be better do use multi-staged docker file : https://medium.com/@albertazzir/blazing-fast-python-docker-builds-with-poetry-a78a66f5aed0#:~:text=Using%20Docker%20multi%2Dstage%20builds
It could be done in an other PR.
There was a problem hiding this comment.
Yes, I'm working on it
There was a problem hiding this comment.
I'm having a docker build problems (proxy/repository). It would be better to deal with this later.
|
This PR can wait a while, another PR is expected very soon to launch poetry on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.